fix: fork checks #194
Merged
fix: fork checks #194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
fmenezes
commented
May 2, 2025
•
fmenezes
commented
- Renames lint to checks
- Moves dependency checks to the main checks workflow
- Enables the checks workflow to run on forks
There was a problem hiding this comment.
Pull Request Overview
This PR updates the GitHub Actions workflow to expand checks beyond linting by adding a new job for dependency checking.
- Renames the workflow from "Lint" to "Checks".
- Adds a new "check-dep" job that installs dependencies, builds the code, removes dev dependencies, and runs an inspection tool.
fmenezes
commented
May 2, 2025
| @@ -42,8 +42,6 @@ jobs: | |||
| permissions: | |||
| pull-requests: write | |||
| contents: write | |||
| needs: | |||
There was a problem hiding this comment.
drive-by: no need, PRs will wait for tests
There was a problem hiding this comment.
I don't see any harm in keeping it though. If we decide to remove these checks for whatever reason we don't want the dependabot to pop up and actually do this
fmenezes
force-pushed
the
fmenezes/test_fork
branch
from
9b6c241 to
0d987aa
Compare
|
cc @nirinchev |
gagik
approved these changes
May 5, 2025
| @@ -42,8 +42,6 @@ jobs: | |||
| permissions: | |||
| pull-requests: write | |||
| contents: write | |||
| needs: | |||
There was a problem hiding this comment.
I don't see any harm in keeping it though. If we decide to remove these checks for whatever reason we don't want the dependabot to pop up and actually do this
nirinchev
added a commit
that referenced
this pull request
May 8, 2025
* main: (40 commits) chore: add more details for some api errors (#219) fix: use ejson parsing for stdio messages (#218) docs: improve getting started experience (#217) feat: support flex clusters to atlas tools (#182) chore: enforce access list (#214) feat: add back the connect tool (#210) Update connection string app name if not present (#199) chore: update docs with more Service Accounts mentions (#209) chore(deps-dev): bump eslint-plugin-prettier from 5.2.6 to 5.4.0 (#205) chore(deps-dev): bump @types/node from 22.15.3 to 22.15.9 (#204) chore(deps-dev): bump typescript-eslint from 8.31.1 to 8.32.0 (#206) chore(deps-dev): bump eslint from 9.25.1 to 9.26.0 (#207) chore: add recommended extensions and settings (#200) fix: fork checks (#194) docs: correct the link for VSCode's MCP usage (#186) chore: switch to a matrix for forks (#191) chore: skip Atlas Tests and don't track coverage for fork contributions (#188) fix: db user test error (#187) fix: improve api error messages (#176) chore: update quickstart with mcpServers (#185) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.